[tech] Add offers for NeTEx France #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
force-pushed
the
netex-france-offre-skeleton
branch
3 times, most recently
from
0b77549 to
c1adf7d
Compare
woshilapin
commented
Feb 13, 2020
src/netex_france/offer.rs
Outdated
Comment on lines
21
to
27
| enum ObjectType { | ||
| _Route, | ||
| _ServiceJourneyPattern, | ||
| _ScheduledStopPoint, | ||
| _PassengerStopAssignment, | ||
| _ServiceJourney, | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
woshilapin
force-pushed
the
netex-france-offre-skeleton
branch
5 times, most recently
from
27bd821 to
838229f
Compare
woshilapin
changed the title
This comment has been minimized.
This comment has been minimized.
woshilapin
force-pushed
the
netex-france-offre-skeleton
branch
4 times, most recently
from
cbde9d0 to
0bca2e6
Compare
ArnaudOggy
previously approved these changes
Feb 25, 2020
src/netex_france/offer.rs
Outdated
| Self::generate_stop_sequence_id( | ||
| &vehicle_journey_id, | ||
| stop_time.sequence, | ||
| ObjectType::ScheduledStopPoint, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
woshilapin
force-pushed
the
netex-france-offre-skeleton
branch
from
0bca2e6 to
1788ac2
Compare
mergify
bot
dismissed
ArnaudOggy’s stale review
Pull request has been modified.
woshilapin
force-pushed
the
netex-france-offre-skeleton
branch
2 times, most recently
from
d9f9a9f to
28b64c4
Compare
ArnaudOggy
previously approved these changes
Feb 25, 2020
src/netex_france/offer.rs
Outdated
| @@ -314,6 +382,36 @@ impl<'a> OfferExporter<'a> { | |||
| .build() | |||
| } | |||
|
|
|||
| fn generate_day_type_ref(vehicle_journey_id: &'a str) -> Element { | |||
There was a problem hiding this comment.
Suggested change
| fn generate_day_type_ref(vehicle_journey_id: &'a str) -> Element { | |
| fn generate_day_type_ref(service_id: &'a str) -> Element { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
woshilapin
force-pushed
the
netex-france-offre-skeleton
branch
from
28b64c4 to
c7ced1b
Compare
mergify
bot
dismissed
ArnaudOggy’s stale review
Pull request has been modified.
woshilapin
force-pushed
the
netex-france-offre-skeleton
branch
from
ea039be to
dc69876
Compare
woshilapin
force-pushed
the
netex-france-offre-skeleton
branch
from
7213dc8 to
4712376
Compare
ArnaudOggy
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.