[feature] Check coherence of Geometries in the model and fix it

[woshilapin]

No description provided.

[datanel]

there is now dead code. https://github.com/CanalTP/transit_model/blob/master/src/apply_rules/property_rule.rs#L397

you may remove the code and add a comment that explains why this case should never happen now.

[woshilapin]

I don't think it is dead code. The geo_id is given by an end-user when configuring an apply-rules process. So it is still possible to end up in this code with an incorrect ID I believe.

[datanel]

This case in the link above means
an object has a geometry_id and there is no geometries in the collection of geometries with id = geometry_id
but this case never happen now with your change.

If I'm wrong you should write the test for this case

and geo_id is not given by end-user but is the geometry_id of an object

[woshilapin]

I pushed a unit test for testing this case.

In term of public API, we indeed accept a Model so the case you're mentioning should never happen. But there is also internal API, like crate::apply_rules::property_rules::update_geometry(), or crate::apply_rules::property_rules::apply_rules() (which accept a Collections, not a Model) that a future developer might use at some point.

[ArnaudOggy]

@Mergifyio refresh

[mergify]

Command refresh: success