[feature] FilterNtfs: filter by line_code #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
force-pushed
the
new_filter_ntfs
branch
from
c024c7b to
c637eed
Compare
This comment has been minimized.
This comment has been minimized.
woshilapin
force-pushed
the
new_filter_ntfs
branch
from
c637eed to
fbb2dd6
Compare
This comment has been minimized.
This comment has been minimized.
woshilapin
force-pushed
the
new_filter_ntfs
branch
from
fbb2dd6 to
73a9a7e
Compare
ArnaudOggy
reviewed
Feb 11, 2020
| } | ||
|
|
||
| #[test] | ||
| fn test_remove_line_by_line_code() { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
woshilapin
force-pushed
the
new_filter_ntfs
branch
5 times, most recently
from
eb211dc to
37f8a80
Compare
ArnaudOggy
force-pushed
the
new_filter_ntfs
branch
from
37f8a80 to
6b04989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works but it's ugly.
something like https://github.com/CanalTP/transit_model/compare/master...datanel:wrap_new_filter_ntfs?expand=1 would be better but it does not compile because model that is moved.