[feature] Export Quays for NeTEx France #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prhod
reviewed
Jan 23, 2020
| @@ -10,7 +10,7 @@ The fare data expected at the input of the connector comes in the form of XML fi | |||
|
|
|||
| The supported fare structures depend on origin-destination (OD) stop pairs in two ways: | |||
| - the ticket price between an origin and a destination is directly specified (*DirectPriceMatrix*) | |||
| - the price for a fare distance unit is specified, as well as the fare distance between an origin and a destination (*UnitPrice* & *DirectMatrix*). The ticket price between the origin and destination stops is computed by multiplying the fare distance by the fare distance unit. In this case, one and only one frame of type *UnitPrice* is expected: if none or more than two are provided, the file is considered invalid and should be discarded. | |||
| - the price for a fare distance unit is specified, as well as the fare distance between an origin and a destination (*UnitPrice* & *DistanceMatrix*). The ticket price between the origin and destination stops is computed by multiplying the fare distance by the fare distance unit. In this case, one and only one frame of type *UnitPrice* is expected: if none or more than two are provided, the file is considered invalid and should be discarded. | |||
There was a problem hiding this comment.
strange to have this here, but thx for the fix 👍
woshilapin
force-pushed
the
netex-france-stop-points
branch
8 times, most recently
from
d459ab9 to
c8db079
Compare
datanel
reviewed
Jan 27, 2020
src/netex_france/stops.rs
Outdated
| // FIXME: String 'EPSG:4326' is failing at runtime (string below is equivalent but works) | ||
| let from = "+proj=longlat +datum=WGS84 +no_defs"; // See https://epsg.io/4326 | ||
| let to = "EPSG:2154"; | ||
| let converter = Proj::new_known_crs(from, to, None).ok_or_else(|| { |
There was a problem hiding this comment.
Will we have a performance issue if we instantiate proj for each stop point?
There was a problem hiding this comment.
Good point, I should be able to create a field of StopPointExporter and initialize it at the construction... I'll rework that.
There was a problem hiding this comment.
Done in 6039817.
woshilapin
force-pushed
the
netex-france-stop-points
branch
from
7628b7b to
f1006a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.