Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] NetexIDF: only 1 active day not skipped #514

Merged
merged 3 commits into from
Jan 17, 2020
Merged

[fix] NetexIDF: only 1 active day not skipped #514

merged 3 commits into from
Jan 17, 2020

Conversation

datanel
Copy link
Member

@datanel datanel commented Jan 16, 2020 •
edited
Loading

  • only one active day not skipped (it was skipped id properties node was not present)
  • order day type assignments
    • Operation days
    • Active days
    • Inactive days

woshilapin
woshilapin reviewed Jan 17, 2020
View reviewed changes
@woshilapin
Copy link
Contributor

Nice new tests to cover the new use cases.

@datanel datanel force-pushed the fix_netexidf_one_active_date branch from 5e94ac0 to 60089d7 Compare January 17, 2020 14:42
woshilapin
woshilapin previously approved these changes Jan 17, 2020
View reviewed changes
@woshilapin woshilapin dismissed their stale review January 17, 2020 14:51

There has been a bug introduced.

@datanel datanel force-pushed the fix_netexidf_one_active_date branch from 60089d7 to 261f94d Compare January 17, 2020 15:03
woshilapin
woshilapin previously approved these changes Jan 17, 2020
View reviewed changes
ArnaudOggy
ArnaudOggy previously approved these changes Jan 17, 2020
View reviewed changes
@datanel datanel force-pushed the fix_netexidf_one_active_date branch from 261f94d to 72548de Compare January 17, 2020 15:21
@mergify mergify bot dismissed stale reviews from woshilapin and ArnaudOggy January 17, 2020 15:22

Pull request has been modified.

@mergify mergify bot merged commit b80ca29 into hove-io:master Jan 17, 2020
@datanel datanel deleted the fix_netexidf_one_active_date branch January 17, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@ArnaudOggy ArnaudOggy ArnaudOggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datanel @woshilapin @ArnaudOggy