[tech] Skeleton for the Netex France exporter #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datanel
reviewed
Jan 10, 2020
woshilapin
force-pushed
the
netex_france_exporter
branch
from
bcdac34 to
5ee949d
Compare
|
In last commit de9f724, I added a few things:
|
datanel
reviewed
Jan 13, 2020
woshilapin
force-pushed
the
netex_france_exporter
branch
from
742b1a4 to
de9f724
Compare
datanel
previously approved these changes
Jan 16, 2020
|
I just added this commit 855e57c to change the way were gonna write timestamp in the file. |
woshilapin
force-pushed
the
netex_france_exporter
branch
from
855e57c to
0ed13e6
Compare
woshilapin
force-pushed
the
netex_france_exporter
branch
from
0ed13e6 to
e1f7c3d
Compare
datanel
previously approved these changes
Jan 16, 2020
ArnaudOggy
previously approved these changes
Jan 16, 2020
mergify
bot
dismissed stale reviews from datanel and ArnaudOggy
Pull request has been modified.
ArnaudOggy
approved these changes
Jan 16, 2020
datanel
approved these changes
Jan 16, 2020
|
@Mergifyio refresh |
datanel
force-pushed
the
netex_france_exporter
branch
from
e1f7c3d to
7e55f2b
Compare
|
Command Hey, I reacted but my real name is @Mergifyio |
|
@Mergifyio refresh |
|
Command Hey, I reacted but my real name is @Mergifyio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a skeleton for the exporter. Trying something new in term of architecture with a
struct(instead of a function) that will own theModeland be responsible for the export. The reason is that we discussed a lot of possible parameters to pass to the binary; theExporteris the structure that would also have these parameters.Note: Putting that PR as a Draft for now. Please tell me what you think of it.