Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tech] added github workflow #507

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

datanel
Copy link
Member

@datanel datanel commented Dec 20, 2019

No description provided.

@woshilapin
Copy link
Contributor

Do we want to change from TravisCI to Github Workflow? Any advantages compared to TravisCI which, so far, seems to do the job pretty well?

@datanel
Copy link
Member Author

datanel commented Jan 6, 2020

It's just a test to see if it's better.and I wonder if it ca be used for private repositories.

@woshilapin
Copy link
Contributor

So I experimented a little bit more with Github Actions when converting CanalTP/kirin and I found a few more things.

For setting up Rust environment, it seems that there is the following actions already implemented that we could use:
https://github.com/actions-rs/toolchain

And more generally, it might be nice to take a look to the repository https://github.com/actions-rs?type=source.

@datanel datanel force-pushed the github_actions branch 4 times, most recently from fc8f593 to 2f30460 Compare February 25, 2020 09:34
@datanel datanel force-pushed the github_actions branch 7 times, most recently from 3e34345 to 3bb874c Compare February 25, 2020 13:09
@woshilapin
Copy link
Contributor

With the feature xmllint, you might also need 2 things if you want the tests to pass:

  • Install libxml2-utils on the machine
  • Pull the submodules (see below)

To pull the submodules, you can use the following step.

            - name: Checkout Submodules
              uses: textbook/[email protected]

@datanel datanel force-pushed the github_actions branch 3 times, most recently from 6c779da to a2b742e Compare February 25, 2020 13:31
woshilapin
woshilapin previously approved these changes Feb 25, 2020
@woshilapin
Copy link
Contributor

Minor: the name of the file of the workflow is not really explicit about what it does main.yml. How about naming it continuous-integration.yml?

@mergify mergify bot dismissed woshilapin’s stale review February 25, 2020 13:42

Pull request has been modified.

@woshilapin woshilapin merged commit 6fd594f into hove-io:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants