Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix conversion from ntfs 10.0 to 11.0 on stoptimes precision #494

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

ArnaudOggy
Copy link
Contributor

@ArnaudOggy ArnaudOggy commented Dec 4, 2019

Fix loss of precision when converting ntfs 10 (and lower) to ntfs 11

For more understanding see the update of the fixtures

  • DEFR 09:24:00 is described in input with a datetime_estimated at 1 (=Estimated), so the output in ntfs 11 on field "precision" should be 2 (=Estimated). This is the goal of this fix.
  • CDGZ 19:26:00 is maybe a ODT area (location_type 2), but the stoptime is overloaded in input with a datetime_estimated at 0 (=Exact), that's why in ouput the same field has at the same value 0 (=Exact). The field "precision" must be similar (0), this was not the case.
  • Stoptimes on ODT areas (without overload) are still functional (datetime_estimated at 1 / =Estimated). See for example MTPZ at 19:24:00.

@ArnaudOggy ArnaudOggy requested a review from patochectp December 4, 2019 15:00
@mergify mergify bot merged commit 4999cad into hove-io:master Dec 5, 2019
@ArnaudOggy ArnaudOggy deleted the fix-odt branch February 20, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants