Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update doc on fares V2>V1 #489

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

papailio
Copy link
Contributor

No description provided.

woshilapin
woshilapin previously approved these changes Nov 29, 2019
* A ticket in `tickets.txt` (with an ID) with:
* A `ticket price` with a validity period, and only a euro currency
* One `ticket use` without constrain on transfers, and empty bording and alighting times
* One `ticket use perimeter` with only the specified network (and no exclusion)
* One `ticket use perimeter` with the specified networks, all associated to the same `ticket_use` (and no exclusion)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand completely here. Is there multiple ticket_use_perimeter to define (one for each network)? If yes, maybe something like this

Suggested change
* One `ticket use perimeter` with the specified networks, all associated to the same `ticket_use` (and no exclusion)
* One `ticket use perimeter` for each specified networks, all associated to the same `ticket_use` (and no exclusion)

Copy link
Contributor

@ArnaudOggy ArnaudOggy Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand completely here. Is there multiple ticket_use_perimeter to define (one for each network)? If yes, maybe something like this

👍
Cardinalities are not clear (for an OD fare or flat fare).
One ticket may have

  • multiple ticket prices (on Y, Y+1 for example)
  • multiple ticket use (although usually only one)
  • multiple ticket use perimeter for one ticket use

Same thing for ticket use restriction.
It's not a problem for v2 to v1 conversion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is only one ticket_use_perimeter with several networks, the same ticket can be used on all networks and do connections between them.
If there is several ticket_use_perimeter each containing a network, the ticket is usable in all networks, but you have to use a new one when having a transfer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is only one ticket_use_perimeter with several networks, the same ticket can be used on all networks and do connections between them.

You can only have one object (network here) by ticket_use_perimeter
https://github.com/CanalTP/ntfs-specification/blob/master/ntfs_fare_extension.md#ticket_use_perimeterstxt-optional

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnaudOggy There could be multiple networks in one ticket_use_perimeter. It's said at least one included line or network. Am I missing something ?
The use case of a Train+Urbain ticket requires multiple networks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be multiple networks in one ticket_use_perimeter. It's said at least one included line or network. Am I missing something ?
The use case of a Train+Urbain ticket requires multiple networks.

Ok I understand what you mean.
You talk about file (ticket_use_perimeters.txt), I'm talking about objects (and csv lines in the file).

object_type | Text | Required | This field can be either line or network
object_id | Text | Required | This field refers to the ID of the considered line or network.

It's not a list. So one ticket_use must have n ticket_use_perimeter (not the file, but instances of the structure ticket_use_perimeters, so csv lines at final) to do Train+Urbain.

@woshilapin woshilapin requested review from woshilapin and removed request for woshilapin November 29, 2019 14:51
@ArnaudOggy ArnaudOggy changed the title Update doc on fares V2>V1 [doc] Update doc on fares V2>V1 Dec 2, 2019
@mergify mergify bot dismissed woshilapin’s stale review December 5, 2019 14:49

Pull request has been modified.

@woshilapin
Copy link
Contributor

I think I'm not competent enough to review this one. I'll leave others review and approve (ping @ArnaudOggy @prhod).

@datanel datanel force-pushed the upd_fares_conversion branch from 26ac216 to ea2b1cf Compare December 9, 2019 10:50
@mergify mergify bot merged commit f2bd631 into hove-io:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants