[feature] apply property rules on co2_emission #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
reviewed
Nov 21, 2019
There was a problem hiding this comment.
In order to test that the a value is replaced, shouldn't the test modify the file tests/fixtures/apply_rules/property_rules.txt?
|
@woshilapin I don't understand your point. |
woshilapin
previously approved these changes
Nov 21, 2019
Hmm, let's put that on the fact I was still sleepy when I did that comment 😴 |
ArnaudOggy
reviewed
Nov 21, 2019
tests/fixtures/apply_rules/output_consolidation_unvalid/physical_modes.txt
Outdated
Show resolved
Hide resolved
mergify
bot
dismissed
woshilapin’s stale review
Pull request has been modified.
woshilapin
approved these changes
Nov 21, 2019
ArnaudOggy
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.