Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tech] Moved apply_rules functions into modules #472

Merged
merged 1 commit into from
Nov 20, 2019
Merged

[tech] Moved apply_rules functions into modules #472

merged 1 commit into from
Nov 20, 2019

Conversation

datanel
Copy link
Member

@datanel datanel commented Nov 19, 2019

I just moved some functions into submodules because appy_rules.rs was big. This is the same code.

It will allow me to do my next PR on apply_rules

woshilapin
woshilapin suggested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work of exploding this big file into multiple modules.

ArnaudOggy
ArnaudOggy previously approved these changes Nov 20, 2019
View reviewed changes
@datanel datanel removed the request for review from patochectp November 20, 2019 12:59
@datanel datanel requested a review from ArnaudOggy November 20, 2019 13:05
@mergify mergify bot merged commit f156068 into hove-io:master Nov 20, 2019
@datanel datanel deleted the aplit_apply_rules branch November 20, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@ArnaudOggy ArnaudOggy ArnaudOggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datanel @woshilapin @ArnaudOggy