[feature] Netex IDF: Add comments for Lines #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
force-pushed
the
netex-line-comments
branch
2 times, most recently
from
7a901a0 to
c634034
Compare
ArnaudOggy
reviewed
Nov 15, 2019
src/netex_idf/lines.rs
Outdated
| @@ -42,7 +42,7 @@ const DEFAULT_TEXT_COLOR: Rgb = Rgb { | |||
| blue: 255, | |||
| }; | |||
|
|
|||
| #[derive(Debug)] | |||
| #[derive(Debug, Default)] | |||
There was a problem hiding this comment.
Default or not Default, that is the question 😆
There was a problem hiding this comment.
Oops, I probably pushed part of what I experimented on the side... It should be fixed now.
woshilapin
force-pushed
the
netex-line-comments
branch
from
c634034 to
3b73596
Compare
ArnaudOggy
approved these changes
Nov 15, 2019
datanel
changed the title
datanel
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.