[feature] NETEX IDF: complementary codes on lines #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
approved these changes
Nov 15, 2019
| let codes: KeysValues = ln | ||
| .private_code | ||
| .clone() | ||
| .map(|pc| vec![("Netex_PrivateCode".into(), pc)].into_iter().collect()) |
There was a problem hiding this comment.
I understand why you do that but isn't the following more easy to read?
|pc| {
let mut codes = BTreeSet::new();
codes.insert(("Netex_PrivateCode".into(), pc));
codes
}There was a problem hiding this comment.
I did like this before but I finally I copied the code from a guy called Jean
https://github.com/CanalTP/transit_model/blame/master/src/netex_idf/offers.rs#L369
😉
woshilapin
approved these changes
Nov 15, 2019
patochectp
approved these changes
Nov 15, 2019
datanel
force-pushed
the
netex_cc_lines
branch
from
4928422 to
f0077a0
Compare
datanel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.