[tech] Exclude all useless files from the Cargo publishing process #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datanel
reviewed
Nov 14, 2019
Cargo.toml
Outdated
| ".gitignore", | ||
| ".mergify.yml", | ||
| ".travis.yml", | ||
| "Cargo.lock", |
There was a problem hiding this comment.
this file appears in the package
There was a problem hiding this comment.
Indeed, I didn't saw that. I guess I can just remove them all... This PR is gonna be simpler 😄
There was a problem hiding this comment.
I've removed all the occurrences of Cargo.lock.
datanel
approved these changes
Nov 14, 2019
datanel
approved these changes
Nov 14, 2019
ArnaudOggy
approved these changes
Nov 14, 2019
datanel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, all of our released crates contained a lot of useless files, particularly all the fixtures files. This
package.excludeshould remove all useless files during the publishing process.