Don't panic when trying to close a connection in "Connecting" state #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's almost impossible to control the state of a
WebSocketif there's a panic here (e.g. being able to start/stop a ws client or server).We must control each connection state to decide how to close a connection to avoid this panic, and most important point, to shutdown the
WebSocket.ws::Sender::shutdownshould never panic, because it's the only way to stop a runningWebSocket, and we should not have to care about the state of connections.It's not happening in release mode, but using this crate in tests seems to be a valid use-case.
Why not using an error log instead?