-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace go-bindata with //go:embed and upgrade to go 1.18 #430
Conversation
Co-authored-by: Luke Jolly <[email protected]>
As far as this discussion of losing the fact that previously building this from main only required Golang and in the current state of this PR, you will now need npm also. As far as I see it, we have three solutions. They're all independent of each other, so any number of them could be chosen:
|
As far as this discussion, I believe I tested that this works. If you run two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Need to resolve merge conflicts.
…ed codebase due to permissions.
replaced by #460 |
What kind of change does this PR introduce? (check at least one)
The PR fulfills these requirements:
If adding a new feature, the PR's description includes:
Other information:
This is an attempt to revive this PR #392. As it as sat for a long time, there are new versions of go available. This PR does the following:
make node_modules
with the latest version of npm (8.13.2) which updated thepackage-lock.json