Progress Bar Won't Render if CSP is Turned On #501
Merged
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress Bar injects inline
<style />
element to page. However, when Content Security Policy is turned on andnonce
is generated - Progress Bar element ignores that.This PR fixes that and checks if
csp-nonce
is set inmeta
tags. Then it uses it to create inline style.Update: I don't know why test is failing and is generating
<style />
withoutnonce
being set. However, when testing manually - this fix works. I might need some help here from someone more experienced in writing JS tests.