Fire turbo:frame-load event during form submission
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, whenever a `<form>` submission drove a `<turbo-frame>` element, `turbo:frame-render` events would fire but `turbo:frame-load` events would not. The implementation to handle navigations initiated by `[src]`-based attribute changes diverges from the code paths that handle form submissions and `4xx` response rendering. Prior to re-structuring those code paths, it's important to ensure that `turbo:frame-load` events fire regardless of how the `<turbo-frame>` was navigated.
seanpdoyle
force-pushed
the
frame-form-fires-load-event
branch
from
1f03db5 to
fe01bac
Compare
|
As far as I understand this is the feature people were asking for in #85, #325 and #520, but just for Turbo Frames and not the whole page. If I may ask, what was the reasoning for this change? I.e. why is a Given this statement:
I fully agree, and I would also argue:
I might be missing something here, sorry if this is a dumb question... Thank you for your great work, BTW! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, whenever a
<form>submission drove a<turbo-frame>element,turbo:frame-renderevents would fire butturbo:frame-loadevents would not. The implementation to handlenavigations initiated by
[src]-based attribute changes diverges fromthe code paths that handle form submissions and
4xxresponserendering.
Regardless of any plans to re-structure those code paths, it's important to ensure that
turbo:frame-loadevents fire regardless of how the<turbo-frame>wasnavigated.