Morph with ignoreActiveValue: true
#1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morph with the [ignoreActiveValue: true][] option to morph the currently focused element's attributes, but preserve its value. This behavior can be extremely helpful when paired with an auto-submitting `<form>` element, like a typeahead `[role="combobox"]`, or an auto-submitting [`<input type="search">`][search]. This commit depends on a fork of `idiomorph` that [fixes a bug related to `ignoreActiveValue: true`][bigskysoftware/idiomorph#34]. [ignoreActiveValue: true]: https://github.com/bigskysoftware/idiomorph#options [search]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search [bigskysoftware/idiomorph#34]: bigskysoftware/idiomorph#34
seanpdoyle
force-pushed
the
preserve-active-element-through-morphing
branch
from
e88194a to
77273ee
Compare
|
@afcapel I've pulled in the latest idiomorph to include bigskysoftware/idiomorph#34 in these changes. |
|
Nice, thanks @seanpdoyle! |
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Feb 21, 2024
Closes [hotwired#1194][] Rolls back [hotwired#1141][] Don't pass the `ignoreActiveValue: true` option when Morphing. To restore that behavior, applications can set `[data-turbo-permanent]` when form control receives focus (through a `focusin` event listener), then remove it if necessary when the form control loses focus (through a `focusout` event listener). [hotwired#1141]: hotwired#1141 [hotwired#1194]: hotwired#1194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Morph with the ignoreActiveValue: true option to morph the currently focused element's attributes, but preserve its value.
This behavior can be extremely helpful when paired with an auto-submitting
<form>element, like a typeahead[role="combobox"], or an auto-submitting<input type="search">.This commit depends on a fork of
idiomorphthat fixes a bug related toignoreActiveValue: true.morphing.while.typing.mov