Set aria-busy on the form element during a form submission #1110
Conversation
This is useful for styling the form while it is submitting. Before this change, we were only setting aria-busy on frames while they were loading and on the html element while Turbo was processing a visit.
|
Wonder if we actually need to set it on the form element itself or if setting it on the body is enough? With frames, do we set it just on the frame or on the root document body? I guess if frames set it on their own element, setting busy on the form makes sense too. |
|
Yes, frames set it on their element. I think it's better to set it on the form, just in case there are several forms in the page. |
|
According to the specification, elements with role="form do support the The aria-busy portion of the specification mentions that it
I think there's some room to interpret what "being updated" means in the context of a With that being said, setting |
|
@seanpdoyle as far as I can tell we're not setting |
|
Given that we already have it scoped with frames, it seems best to follow that pattern with forms too. Especially, as @afcapel says, you could have multiple forms per page, and we want to be able to use aria-busy to style which one is submitting. |
* origin/main:
Introduce `turbo:{before-,}morph-{element,attribute}` events
Turbo 8.0.0-beta.4
Introduce data-turbo-track="dynamic" (hotwired#1140)
Ensure that the turbo-frame header is not sent when the turbo-frame has a target of _top (hotwired#1138)
Turbo 8.0.0-beta.3
Fix attribute name (hotwired#1134)
Add InstantClick behavior (hotwired#1101)
Revert hotwired#926. (hotwired#1126)
Keep Trix dynamic styles in the head (hotwired#1133)
Remove unused stylesheets when navigating (hotwired#1128)
Upgrade idiomorph to 0.3.0 (hotwired#1122)
Debounce page refreshes triggered via Turbo streams
Update copyright year to 2024 (hotwired#1118)
Turbo 8.0.0-beta.2
Set aria-busy on the form element during a form submission (hotwired#1110)
Dispatch `turbo:before-fetch-{request,response}` during preloading (hotwired#1034)
…1110) This is useful for styling the form while it is submitting. Before this change, we were only setting aria-busy on frames while they were loading and on the html element while Turbo was processing a visit.
This is useful for styling the form while it is submitting.
Before this change, we were only setting aria-busy on frames while they were loading and on the html element while Turbo was processing a visit.