Change default action for form submissions that redirect to the current location #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt location This changes the default action for form submission that redirect to the current location from "advance" to "replace". This makes more sense since we're re-rendering the current page, there should be no new entry in the history. We are also changing the morphing behaviour to only kick in when the visit action is "replace". This is to avoid morphing the page when, for example, we are follwing a link, unless we opt in to morphing by setting the data-turbo-action attribute to replace. The main use case for morphing remains the same: you submit a form that changes some state and refirect to the same location. Turbo handles the redirect and morphs the page to reflect the new state.
| @@ -307,6 +307,18 @@ test("clicking the forward button", async ({ page }) => { | |||
| assert.equal(await visitAction(page), "restore") | |||
| }) | |||
|
|
|||
| test("form submissions that redirect to a different location have a default advance action", async ({ page }) => { | |||
There was a problem hiding this comment.
I would add a page refresh test to validate that morphing doesn't trigger if you click on a link pointing to the current page.
domchristie
pushed a commit
to domchristie/turbo
that referenced
this pull request
Jul 20, 2024
…nt location (hotwired#1072) * Change default action for form submissions that redirect to the current location This changes the default action for form submission that redirect to the current location from "advance" to "replace". This makes more sense since we're re-rendering the current page, there should be no new entry in the history. We are also changing the morphing behaviour to only kick in when the visit action is "replace". This is to avoid morphing the page when, for example, we are follwing a link, unless we opt in to morphing by setting the data-turbo-action attribute to replace. The main use case for morphing remains the same: you submit a form that changes some state and refirect to the same location. Turbo handles the redirect and morphs the page to reflect the new state. * Add parentheses to clarify conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default action for form submission that redirect to the current location from "advance" to "replace". This makes more sense since we're re-rendering the current page, there should be no new entry in the history.
We are also changing the morphing behaviour to only kick in when the visit action is "replace". This is to avoid morphing the page when, for example, we are following a link, unless we opt in to morphing by setting the data-turbo-action attribute to replace.
The main use case for morphing remains the same: you submit a form that changes some state and redirect to the same location. Turbo handles the redirect and morphs the page to reflect the new state.