-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation #530
Conversation
0e61120
to
56122d6
Compare
56122d6
to
2d885a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great one @brunoprietog. There is a committed merge conflict. If you fix that I'll merge. Thanks!
2d885a7
to
8fe047d
Compare
Co-authored-by: Jorge Manrubia <[email protected]>
* origin/main: Improve documentation (#530)
# You can broadcast "page refresh" stream actions. This will make subscribed clients reload the | ||
# page. For pages that configure morphing and scroll preservation, this will translate into smooth | ||
# updates when it only updates the content that changed. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jorgemanrubia, this blank line is causing everything above not to show. I've opened #571 to fix this and other small minor details that I missed.
Currently, for newcomers, it is difficult to find the appropriate documentation to understand the value of turbo-rails and discover what it is capable of. If they reach RDoc, it is not intuitive to identify which classes and modules are responsible for the specific behavior of each part of turbo-rails oriented towards developers. We should make this information more visible to make it easier to get started.
This PR includes several typo corrections, suggestions from #516 and #524, documentation for some undocumented methods, and some explanations about page refreshes.
Additionally, in the README, the most important links to RDoc are included to make it easier to find and read the documentation.
Please, I would love to receive feedback.