Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #530

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

brunoprietog
Copy link
Contributor

Currently, for newcomers, it is difficult to find the appropriate documentation to understand the value of turbo-rails and discover what it is capable of. If they reach RDoc, it is not intuitive to identify which classes and modules are responsible for the specific behavior of each part of turbo-rails oriented towards developers. We should make this information more visible to make it easier to get started.

This PR includes several typo corrections, suggestions from #516 and #524, documentation for some undocumented methods, and some explanations about page refreshes.

Additionally, in the README, the most important links to RDoc are included to make it easier to find and read the documentation.

Please, I would love to receive feedback.

@brunoprietog brunoprietog force-pushed the docs-improvements branch 2 times, most recently from 0e61120 to 56122d6 Compare December 29, 2023 23:31
Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one @brunoprietog. There is a committed merge conflict. If you fix that I'll merge. Thanks!

app/helpers/turbo/drive_helper.rb Outdated Show resolved Hide resolved
@jorgemanrubia jorgemanrubia merged commit d7155dd into hotwired:main Feb 7, 2024
15 checks passed
@brunoprietog brunoprietog deleted the docs-improvements branch February 7, 2024 10:56
afcapel added a commit that referenced this pull request Feb 8, 2024
* origin/main:
  Improve documentation (#530)
This was referenced Feb 8, 2024
# You can broadcast "page refresh" stream actions. This will make subscribed clients reload the
# page. For pages that configure morphing and scroll preservation, this will translate into smooth
# updates when it only updates the content that changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jorgemanrubia, this blank line is causing everything above not to show. I've opened #571 to fix this and other small minor details that I missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants