Error handling improvements #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
commented
Jan 8, 2021
| @@ -1,7 +1,7 @@ | |||
| import { ControllerTestCase } from "../cases/controller_test_case" | |||
| import { ClassController } from "../controllers/class_controller" | |||
|
|
|||
| export default class ValueTests extends ControllerTestCase(ClassController) { | |||
| export default class ClassTests extends ControllerTestCase(ClassController) { | |||
There was a problem hiding this comment.
this change isn't related to this PR, it just fixes an incorrect class name
There was a problem hiding this comment.
Thank you! Fixed in main by caecf0f
ghiculescu
force-pushed
the
error-handling-tools-integration
branch
6 times, most recently
from
e37a2be to
96256e4
Compare
|
Any chance that this is going to be merged in? I just went down a 4 hour rabbit hole trying to figure out why Sentry wasn't getting called unless I explicitly called it. Now that I see this PR, I see what's happening, but man was it a long road to find this. |
sstephenson
suggested changes
Mar 24, 2021
| @@ -1,7 +1,7 @@ | |||
| import { ControllerTestCase } from "../cases/controller_test_case" | |||
| import { ClassController } from "../controllers/class_controller" | |||
|
|
|||
| export default class ValueTests extends ControllerTestCase(ClassController) { | |||
| export default class ClassTests extends ControllerTestCase(ClassController) { | |||
There was a problem hiding this comment.
Thank you! Fixed in main by caecf0f
Proposing some changes that I mentioned [here](hotwired#236 (comment)). To recap, I think the error logging in Stimulus is great, but several people (me included) have been caught by the fact that errors aren't reported elsewhere out of the box. The aim of this PR is to automatically integrate with third party error tracking services where possible, and to improve the documentation where not. Specific changes: - If `window.onerror` is defined, Stimulus will now call it after logging an error. Many error tracking tools define this method, eg. [Sentry](https://github.com/getsentry/sentry-javascript/blob/0ee07995d415d3870608c477cbdcf8445a51e1bb/packages/browser/src/loader.js#L192), [Airbrake](https://github.com/airbrake/airbrake-js/blob/9d4787b1c559aa39107d7288f46c4108c9a9d954/packages/browser/src/notifier.ts#L70) - Added documentation on how error handling works, including what happens out of the box and how to override it (with code sample from hotwired#53) - Added tests for the error handler.
ghiculescu
force-pushed
the
error-handling-tools-integration
branch
from
96256e4 to
0dcdfc4
Compare
|
Thanks @sstephenson, made those fixes. |
|
Fantastic! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing some changes that I mentioned here. To recap, I think the error logging in Stimulus is great, but several people (me included) have been caught by the fact that errors aren't reported elsewhere out of the box. The aim of this PR is to automatically integrate with third party error tracking services where possible, and to improve the documentation where not.
Specific changes:
window.onerroris defined, Stimulus will now call it after logging an error. Many error tracking tools define this method, eg. Sentry, Airbrake.