Breaking API change: applications can set a User-Agent prefix #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemasilotti
commented
Dec 12, 2024
joemasilotti
commented
Dec 12, 2024
| @@ -1,15 +1,29 @@ | |||
| import Foundation | |||
| import HotwireNative | |||
| @testable import HotwireNative | |||
There was a problem hiding this comment.
@testable is needed to access the (now) internal UserAgent function.
joemasilotti
commented
Dec 12, 2024
Demo/SceneController.swift
Outdated
Comment on lines
15
to
17
| // TODO: Move to AppDelegate when PR #55 is merged. | ||
| // https://github.com/hotwired/hotwire-native-ios/pull/55/files | ||
| Hotwire.config.applicationUserAgentPrefix = "Hotwire Demo;" |
There was a problem hiding this comment.
Commenting so we don't forget about this to-do.
* main: Set session's path config from the global path config. Consolidate all global config by moving it in app delegate. Add utility func to load path config to the Hotwire enum. Move `matchQueryStrings` to `PathConfiguration`. Move `registerBridgeComponents` to `AppDelegate`.
svara
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings Android PR #77 to iOS, allowing developers to set a custom user agent prefix without breaking bridge components or removing "Hotwire Native".
Developers can set a custom
applicationUserAgentPrefixfor their application via:Whenever a
WKWebViewinstance is created, the library will now automatically include:applicationUserAgentPrefixWKWebView's default user agent will also be added to the beginning of the user agent.