Set AMI to debian for staging and prod deployment #6583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mahesh-naxa
approved these changes
Oct 4, 2024
tsmock
reviewed
Nov 7, 2024
| @@ -357,7 +357,7 @@ workflows: | |||
| name: Deploy backend production | |||
| gitsha: $CIRCLE_SHA1 | |||
| stack_name: "tm4-production" | |||
| host_ami: "/aws/service/canonical/ubuntu/server/20.04/stable/current/amd64/hvm/ebs-gp2/ami-id" | |||
| host_ami: "/aws/service/debian/release/11/20240813-1838/amd64" | |||
There was a problem hiding this comment.
Why not /aws/service/debian/release/11/latest/amd64 (currently set to the 2024-10-07 Debian image)?
There was a problem hiding this comment.
My logic is that using latest could introduce a breaking or unintended change. Even at a low chance I would rather avoid it, and this code is going to be depreciated soon anyways so no long-term planning needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Describe this PR
This change sets the deployment backend server environment to use debian AMI