Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup backend dockerfile #6436

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

eternaltyro
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

  • Upgrade pdm and pydebug versions
  • Reduce RUN layers for apt steps
  • Remove gunicorn workers parameter to allow for WEB_CONCURRENCY env

Review Guide: Notes for the reviewer

Gunicorn worker count is recommended to be 2-4 x $(NUM_CORES) . Default is 1. For production deployments we can rely on WEB_CONCURRENCY envvar to set the number of cores.

Checklist before requesting a review

- Upgrade pdm and pydebug versions
- Reduce RUN layers for apt steps
- Remove gunicorn workers parameter to allow for WEB_CONCURRENCY env

Signed-off-by: eternaltyro <[email protected]>
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required β‰₯ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dakotabenjamin dakotabenjamin merged commit 77b26c1 into develop Sep 3, 2024
7 of 9 checks passed
spwoodcock added a commit to spwoodcock/tasking-manager that referenced this pull request Sep 4, 2024
emi420 pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants