Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/OSM Download meta data integration #6222

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

varun2948
Copy link
Contributor

@varun2948 varun2948 commented Jan 29, 2024

What does this PR do ?

  • Meta data shown to let user know it's updated date and size.

Consideration

-On previous approach , We didn't had any metadata, which was causing user to know last updated date and the actual size of the files.

How to test ?

-You can see two text one on side of the download with size of the file i.e. Geojson (2.4mb) and one below the filetype as last modified date as shown in the picture.

image

@varun2948 varun2948 changed the title Feature/ OSM Download meta data integration Feature/OSM Download meta data integration Jan 29, 2024
@varun2948
Copy link
Contributor Author

just fixed the frontend sonarlint issue @kshitijrajsharma, @kaditya97 can you see what is causing that issue ?

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kshitijrajsharma kshitijrajsharma merged commit 9b81747 into hotosm:develop Jan 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants