-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/OSM Download meta data integration #6222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun2948
requested review from
kshitijrajsharma,
royallsilwallz and
ramyaragupathy
January 29, 2024 10:13
varun2948
changed the title
Feature/ OSM Download meta data integration
Feature/OSM Download meta data integration
Jan 29, 2024
just fixed the frontend sonarlint issue @kshitijrajsharma, @kaditya97 can you see what is causing that issue ? |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 5 New issues |
kshitijrajsharma
approved these changes
Jan 29, 2024
royallsilwallz
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Consideration
-On previous approach , We didn't had any metadata, which was causing user to know last updated date and the actual size of the files.
How to test ?
-You can see two text one on side of the download with size of the file i.e. Geojson (2.4mb) and one below the filetype as last modified date as shown in the picture.