-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra: tm-exporter lambda function using terragrunt. #6189
Conversation
hi @dakotabenjamin i have added added raw_data_api & active_projects_api_base_url as inputs on all sets of dev,stag,prod so, only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm setting my review as "Request Changes" because everything looks good but I need some clarification. Once the questions are addressed here in in the TM-Extractor repo, I think this is good to merge.
# needs to deploy a different module version, it should redefine this block with a different ref to override the | ||
# deployed version. | ||
terraform { | ||
# Sourcing from here rn, updating to a release from https://github.com/hotosm/TM-Extractor/ later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to make my tests work, I had to replace the source with my local build of TM-extractor where I set the required terraform version to ~>1.6.0
. See hotosm/TM-Extractor#3 for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that would be nice to have minor patches allowed, only thing is that once we have our CircleCi config for deployments how would we make sure they align. Else i am all okay.
I have updated TM-Extractor's v.1.0.1 to be source. I see it has updated code on =1.6.0
.
# Set common variables for the environment. This is automatically pulled in in the root terragrunt.hcl configuration to | ||
# feed forward to the child modules. | ||
|
||
locals { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be set with example defaults as a env.hcl.example
with README instructions to replace and rename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be up to us to have it already created. I have updated README.md
within scripts/aws/lambda/TM-Extrator/
with this information.
@dakotabenjamin However i had no clue on what stag/prod input vars will be for account_name
, account_region
. Can you have that updated for stag/prod.
b53bf99
to
55b7303
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Resolves Export tool integration: infrastructure tasks #6146 Export tool integration: Setting up a lambda function to track active projects and schedule export jobs #6145
Adds terraform snippet for creating lambda function, cloudwatch event, alarms & policies.
Adds lambda layer for requests library (import from s3 or provide layer arn later. )
Note:
TF_VAR_rawdata_api_auth_token
, Auth token for raw data api, Request here.TF_VAR_raw_data_api
, API endpoint. Defaults to https://api-prod.raw-data.hotosm.org/v1TF_VAR_active_projects_api_base_url
, Your tasking-manager instance.Defaults to https://tasking-manager-staging-api.hotosm.org/api/v2