-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sentry replays and source maps #6032
Conversation
d1f5fff
to
91d7efb
Compare
frontend/package.json
Outdated
"@sentry/tracing": "^7.56.0", | ||
"@sentry/react": "^7.60.1", | ||
"@sentry/tracing": "^7.60.1", | ||
"@sentry/browser": "^7.60.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find any instances where @sentry/browser
package is being utilized. From the React | Sentry Docs
All methods available in
@sentry/browser
can be imported from @sentry/react.
Since we are already using @sentry/react
in our project, it might be a good idea to consider removing the unused @sentry/browser
.
frontend/src/index.js
Outdated
@@ -16,8 +16,22 @@ if (SENTRY_FRONTEND_DSN) { | |||
Sentry.init({ | |||
dsn: SENTRY_FRONTEND_DSN, | |||
environment: ENVIRONMENT, | |||
integrations: [new BrowserTracing()], | |||
integrations: [ | |||
new BrowserTracing(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a separate note (unrelated to the changes made in this PR), the BrowserTracing
import from @sentry/tracing
is now deprecated. It's recommended to directly import it from our framework-specific SDK, @sentry/react
. This lets us remove the @sentry/tracing
package altogether.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR adds sentry replays and source maps for improved frontend tracking