Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry replays and source maps #6032

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Conversation

dakotabenjamin
Copy link
Member

This PR adds sentry replays and source maps for improved frontend tracking

@github-actions github-actions bot added scope: frontend dependencies Pull requests that update a dependency file javascript labels Aug 17, 2023
"@sentry/tracing": "^7.56.0",
"@sentry/react": "^7.60.1",
"@sentry/tracing": "^7.60.1",
"@sentry/browser": "^7.60.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any instances where @sentry/browser package is being utilized. From the React | Sentry Docs

All methods available in @sentry/browser can be imported from @sentry/react.

Since we are already using @sentry/react in our project, it might be a good idea to consider removing the unused @sentry/browser.

@@ -16,8 +16,22 @@ if (SENTRY_FRONTEND_DSN) {
Sentry.init({
dsn: SENTRY_FRONTEND_DSN,
environment: ENVIRONMENT,
integrations: [new BrowserTracing()],
integrations: [
new BrowserTracing(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a separate note (unrelated to the changes made in this PR), the BrowserTracing import from @sentry/tracing is now deprecated. It's recommended to directly import it from our framework-specific SDK, @sentry/react. This lets us remove the @sentry/tracing package altogether.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dakotabenjamin dakotabenjamin merged commit b7563bf into develop Aug 23, 2023
3 checks passed
@dakotabenjamin dakotabenjamin deleted the add/6006-sentry-replays branch August 23, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants