-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Transifex #5822
Update Transifex #5822
Conversation
Kudos, SonarCloud Quality Gate passed! |
@d-rita The localization files found in |
Is this PR related to #5072? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@HelNershingThapa this PR only updates the tx/config file. In order to update the localisation files, we'd have to first pull the translated strings from the Transifex repo. And we have not done that yet. |
Yes. Was not aware of this PR but it updates the config file and localisation files as well. cc: @dakotabenjamin |
Will that be a part of this PR? |
That is to be determined. The last time we had discussed this issue we had talked about creating a PR to update translations before the next release. Whether it is with this PR or another, we'd have to agree. cc: @Ichchhie @ramyaragupathy |
After some thought, I have come around that we should merge this now and add translations in a new pull request. |
What does this PR do?
Steps taken:
tx migrate
to update the config filecontributing translations section
of the documentationHow to test:
tx push -s
to push the source file to the Transifex repo ortx pull -af --mode translator
to pull all translated language changes to the TM project. The translation files live in the frontend/src/locales folder.