Update docker-compose and other docker files

[tsmock]

• Update Makefile so it works (app -> backend/frontend, depending upon context)
• Use an official postgis image (that is actually updated, mdillon/postgis:11 -> postgis/postgis:11-3.1 (3.1 is the postgis version)
• Use official node images (tiangolo/node-frontend:10 -> node:14 (node 10 is no longer supported, and node 12 EOL is less than a year away).

[willemarcel]

Thanks, @tsmock!! @d-rita Could you review it when you have the possibility?

[eternaltyro]

Now that we have tested later versions of Node and Postgres (and Postgis), we can safely upgrade version tags for both of them.

When that's done, this PR is good to go.

[tsmock]

I need to do some fiddling. It has been awhile since I made this PR, so I need to reverify everything.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
2 Security Hotspots
0 Code Smells

No Coverage information
0.4% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[Aadesh-Baral]

@tsmock Is this ready for review?

cc @eternaltyro

[tsmock]

I don't remember if I decided it was ready or not. I'll rebase onto current dev and see if it all works.

I got distracted by some other stuff (mostly going through dependencies on the frontend or working on JOSM).

[tsmock]

OK. I've been going over some of the code:

• I think HEALTHCHECK --interval=60s --start-period=15s CMD ["curl", "-f", "http://localhost:8000/api/v2/system/heartbeat/", "||", "exit", "1"] will work, but I haven't verified it.

podman-compose up is working properly insofar as starting everything. I probably messed up the network configuration (I wasn't able to connect).

[Aadesh-Baral]

podman-compose up is working properly insofar as starting everything. I probably messed up the network configuration (I wasn't able to connect).

Could you please clarify where you were unable to connect?

[dakotabenjamin]

@tsmock on the HEALTHCHECK, docker compose runs the frontend/backend on port 80. In addition, I needed to change the following to get it to work:

diff --git a/docker-compose.yml b/docker-compose.yml
index 31f1db1f..bfcfb9cb 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -59,4 +59,4 @@ services:
 
 networks:
   tm-web:
-    external: true
+    external: false

This doesn't have to do with your PR, I'm not even really sure why it was set as external in the first place. I think the docs for running/developing with Docker sorely need updating, but I don't think we need to require that to merge this PR. With the two changes suggested above, I think this is good to go, and we can follow up with a cleanup/clarity PR.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.5% Duplication

[dakotabenjamin]

LGTM

changes have been made