Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OAM styles #2

Merged
merged 3 commits into from
Feb 15, 2017
Merged

add OAM styles #2

merged 3 commits into from
Feb 15, 2017

Conversation

LindaAlblas
Copy link
Contributor

No description provided.

Copy link
Contributor

@hunt3ri hunt3ri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed couple of minor naming points

.pipe(gulp.dest('../server/web/static/dist'));
});

gulp.task('sass', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend renaming to compile-sass

/** Minify all CSS and output to dist - Docs for CSSNano are here https://github.com/ben-eb/cssnano */

return gulp.src(paths.styles)
.pipe(concat('main.min.css'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend renaming to taskingmanager.min.css

Copy link
Contributor

@hunt3ri hunt3ri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good lets 🚢

@hunt3ri hunt3ri merged commit b5553ad into develop Feb 15, 2017
@hunt3ri hunt3ri deleted the add-oam-styles branch February 16, 2017 12:08
fitoria pushed a commit that referenced this pull request Jun 3, 2019
# This is the 1st commit message:

task annotation model

migration

api outline

service outline

add or update annotation. make the api based on type. remove type as enum

migration

annotation dto and get request per project.

api docs

get method to get all annotation types. remove annotation type from projectdto

make annotation_type optional in docs

mention annotation_type in the api docs

return 200 with the project id once annotations are added

First set of app token

Add application key db revision

Build out application key backend

Typo fixes

Revision of app key backend

use application token for posting annotations

Update migrations

return after all the annotations are added. duh

# This is the commit message #2:

fix migrations on merge with develop

# This is the commit message #3:

adds default value to json
ramyaragupathy added a commit that referenced this pull request Feb 28, 2020
# This is the 1st commit message:

Restrict edit permissions for projects

Code formatting

Let ADMIN and Authors access private projects

# This is the commit message #2:

Formatting

# This is the commit message #3:

Updated project_info formatting

# This is the commit message #4:

Featured projects endpoint

# This is the commit message #5:

Message for ValueError

# This is the commit message #6:

Chat Service related

# This is the commit message #7:

References update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants