Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TM_ORG_URL should include http:// or https:// #6165

Closed
frafra opened this issue Dec 14, 2023 · 0 comments · Fixed by #6569
Closed

TM_ORG_URL should include http:// or https:// #6165

frafra opened this issue Dec 14, 2023 · 0 comments · Fixed by #6569
Labels
deployment Release deployment or hotfixes dev-setup 🛠️ scope: documentation Any issue that relates to documentation edits, updates, improvements scope: frontend

Comments

@frafra
Copy link
Contributor

frafra commented Dec 14, 2023

I updated the tasking manager on a server, and I found it was generating a broken link in the header.

This is because the example.env specifies that TM_ORG_URL and TM_ORG_PRIVACY_POLICY_URL should not include the protocol:

# Don't use http or https on the following two variables
TM_ORG_URL=example.com
TM_ORG_PRIVACY_POLICY_URL=https://www.hotosm.org/privacy

This is not correct, since the frontend does not add the protocol:

<a className="link red f6 mr2" href={`${ORG_URL}`} target="_blank" rel="noreferrer">

This is because of a change that has not been reflected in the example file:

74d130d#diff-7918370b89a458b03dac0ed4fdce697153cd37e684b6fa52a2532f7c7e50195e

@ramyaragupathy ramyaragupathy added dev-setup 🛠️ scope: documentation Any issue that relates to documentation edits, updates, improvements deployment Release deployment or hotfixes labels May 1, 2024
erictheise added a commit to OpenHistoricalMap/tasking-manager that referenced this issue Sep 20, 2024
…on about not using scheme on "next two variables". Second example does indeed include scheme and first example produces an incorrect link without scheme included.
ramyaragupathy added a commit that referenced this issue Oct 23, 2024
…L-should-include-scheme

Addresses #6165 by removing incorrect and conflicting instruction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Release deployment or hotfixes dev-setup 🛠️ scope: documentation Any issue that relates to documentation edits, updates, improvements scope: frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants