-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve the proc-block bootstrapping problem #353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es from crates.io
…em to hotg-ai/proc-blocks
The semver-trick is interesting. |
…g the native library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area - codegen
The code gets generated when compiling a Rune
area - proc blocks
Procedural blocks linked to by the compiled Rune
area - runtime
The Rust Rune runtime
category - bug
Something isn't working
category - refactor
Internal code changes or reworking that aren't directly visible to the user
effort - hard
This should be pretty simple to fix
priority - urgent
This needs to be done ASAP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying problem with #247 is that we were giving "builtin" proc blocks special treatment while developing, meaning sometimes they would try to use
hotg-rune-core
and friends from crates.io, other times it would use versions from local files on disk or git.This resolves the issue by:
hotg-ai/proc-blocks
)hotg-rune-core
from crates.io, like every other proc blockCargo.toml
which will make each Rune use thehotg-rune-core
version that matches whathotg-rune-compiler
was built againsthotg-rune-core
work with the newer version when the APIs being used are compatible, even if thehotg-rune-core
crate's versions are different... I think I've correctly threaded the needle here 🤞
Fixes #247.
cc: @f0rodo, @Mohit0928, @saidinesh5