Reading metadata from a non-WebAssembly file creates an infinite iterator #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way
wasmparser
'sParser::parse_all()
method is implemented, triggering a "bad magic number" error won't let the parser make any progress, meaning if you don'tbreak
on errors you'll get an infinite iterator.Later on we skip any errors and try to iterate over every
Payload
in the infinite iterator, causing commands likerune inspect
andrune run
to run forever.Fixes #315.