check if err is nil before printing it #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I noticed that when exiting out of the bootstrap setup server using Ctrl-C, the script would throw a runtime error similar to this:
Took a bit of time to find it, but I think I found the solution. Turns out it was trying to dereference nil (
err.Error()
) which was the value of err in the case when a user hits Ctrl-C to exit of the server.With that small nil check added, it exited out of the bootstrap server a bit more gracefully.
Hope this helps and Atlantis looks great by the way! 👍