Adding github webhook secret key option. Fixes #34 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
reviewed
Aug 14, 2017
| @@ -301,6 +303,15 @@ func (s *Server) postEvents(w http.ResponseWriter, r *http.Request) { | |||
| githubReqID := "X-Github-Delivery=" + r.Header.Get("X-Github-Delivery") | |||
| var payload []byte | |||
|
|
|||
| // validate payload if github webhook secret key is set | |||
| if s.eventParser.GithubWehbookSecretKey != "" { | |||
| _, err := gh.ValidatePayload(r, []byte(s.eventParser.GithubWehbookSecretKey)) | |||
There was a problem hiding this comment.
this doesn't work if the webhook is set up using x-www-form-urlencoded
There was a problem hiding this comment.
I think it would right? I am checking for secret key before we even determine whether the request is Content-Type is json or x-www-form-urlencoded.
|
Can we close this in favor of #120? |
|
Yes sir. 👍 |
|
Yeah but if you see my pr you see that in the form version it's not the
json string that is used for the signature.
…On Sun, Aug 13, 2017, 11:03 PM Anubhav Mishra ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In server/server.go
<#119 (comment)>:
> @@ -301,6 +303,15 @@ func (s *Server) postEvents(w http.ResponseWriter, r *http.Request) {
githubReqID := "X-Github-Delivery=" + r.Header.Get("X-Github-Delivery")
var payload []byte
+ // validate payload if github webhook secret key is set
+ if s.eventParser.GithubWehbookSecretKey != "" {
+ _, err := gh.ValidatePayload(r, []byte(s.eventParser.GithubWehbookSecretKey))
I think it would right? I am checking for secret key before we even
determine whether the request is Content-Type is json or
x-www-form-urlencoded.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_IvQ1EI5JUg_-YLfxDDl8ZGpLUWL3fks5sX-MqgaJpZM4O1zdp>
.
|
malnick
pushed a commit
to BlueOwlDev/atlantis
that referenced
this pull request
Jun 21, 2018
Fix Docker images not building.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-webhook-secret-keyto supply Github webhook secret key to verify payloads.TODO: