XSD include caching incorrectly identifies multiple xsd files as the same file. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…=file1.xsd endpoint?xsd=file2.xsd
wdreeveii
force-pushed
the
include_cache_fix
branch
from
17390ec to
6ecb553
Compare
wdreeveii
force-pushed
the
include_cache_fix
branch
from
17390ec to
623ec3f
Compare
|
Closing since #48 supersedes this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xsd file 'caching' is overly broad and identifies http://fqdn/some/endpoint?xsd=file1.xsd as the same include as http://fqdn/some/endpoint?xsd=file2.xsd. I think hosting several files at the same endpoint is fairly common practice, and I see no downsides to this change.
Thanks