Implement xml.Unmarshaller for SOAPBody #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR to get some feedback since I'm very new at writing Go code.
These changes allow unmarshalling and marshalling to happen in a single pass, which allows a broader range of SOAP responses to be parsed. In particular, it handles the case where the
xmlns
used on the<SOAP-ENV:Body>
entries is declared on a parent element instead of on the entry itself.I would have liked to add some tests here, but I'm not clear on how to structure tests that use the generated code from
soap_tmpl.go
. I'm happy to add some tests if someone can give me some pointers on how to do so. I was able to runmake test
, so I at least don't think I broke any of the existing tests.Fixes #37