Xsd date and time support #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 15, 2021 23:01
…date-and-time-support
|
Awesome, I will take a look at this PR during the weekend. Thank you! |
c4milo
reviewed
Feb 28, 2021
| @@ -33,7 +33,7 @@ type Document struct { | |||
| // The date the message was created. Used for auditing and logging. | |||
| // | |||
|
|
|||
| CreationDate time.Time `xml:"creationDate,attr,omitempty" json:"creationDate,omitempty"` | |||
| CreationDate soap.XsdDateTime `xml:"creationDate,attr,omitempty" json:"creationDate,omitempty"` | |||
There was a problem hiding this comment.
In Go, the naming convention will be XSDDateTime
There was a problem hiding this comment.
Please find the PR for fixing it here: #196
|
LGTM! only a minor non-blocking nitpick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support to xsd:date, xsd:datetime, and xsd:time by referencing the code at https://github.com/NYTimes/encoding-wrapper/blob/master/elementalconductor/time.go
But it actually isn't quite fully covering the various string literals of these types as described at:
xsd:time => http://books.xmlschemata.org/relaxng/ch19-77311.html
xsd:date => http://books.xmlschemata.org/relaxng/ch19-77041.html
xsd:datetime => http://books.xmlschemata.org/relaxng/ch19-77049.html
So I used similar idea to develop a better implementation of XsdDate, XsdDateTime and XsdTime.
Please let me know if you have any comments.
The code has been tested against our product and SOAP service, and "go test" can have a PASS.
Thanks and regards