Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/empty connection name #76

Merged
merged 3 commits into from
May 8, 2024
Merged

Fix/empty connection name #76

merged 3 commits into from
May 8, 2024

Conversation

leggetter
Copy link
Collaborator

replaces #74

@leggetter leggetter mentioned this pull request May 8, 2024
Closed
alexluong
alexluong approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@alexluong alexluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since #74 was previously approved

@leggetter leggetter merged commit e8f1bf5 into master May 8, 2024
4 checks passed
@leggetter leggetter deleted the fix/empty-connection-name branch May 8, 2024 13:01
@baileywickham baileywickham mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexluong alexluong alexluong approved these changes

@alexbouchardd alexbouchardd Awaiting requested review from alexbouchardd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leggetter @alexluong