Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more table options #59

Merged
merged 5 commits into from
Jan 27, 2022
Merged

Feature/more table options #59

merged 5 commits into from
Jan 27, 2022

Conversation

hoogi91
Copy link
Owner

@hoogi91 hoogi91 commented Jan 24, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #58

@hoogi91 hoogi91 self-assigned this Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #59 (9d88580) into develop (f408e33) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #59      +/-   ##
===========================================
+ Coverage    99.60%   99.61%   +0.01%     
===========================================
  Files           21       22       +1     
  Lines          750      779      +29     
===========================================
+ Hits           747      776      +29     
  Misses           3        3              
Flag Coverage Δ
phpunit 99.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Classes/DataProcessing/AbstractProcessor.php 100.00% <100.00%> (ø)
Classes/DataProcessing/SpreadsheetProcessor.php 100.00% <100.00%> (ø)
Classes/DataProcessing/TabsProcessor.php 100.00% <100.00%> (ø)
Classes/ViewHelpers/Cell/RenderViewHelper.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f408e33...9d88580. Read the comment docs.

Copy link
Owner Author

@hoogi91 hoogi91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve cell rendering

@hoogi91 hoogi91 merged commit a7003f9 into develop Jan 27, 2022
@hoogi91 hoogi91 deleted the feature/more-table-options branch June 24, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant