Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for fortran.snippets #1329

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tammasloughran
Copy link

@tammasloughran tammasloughran commented Mar 3, 2021

The default Fortran snippets left me wanting more. Here are some suggestions.

Regarding the original procedure snippet: that wasn't how the procedure statement works in Fortran. It's just used as declarations in interfaces.

There are some naming changes to make it feel more like tab completion/distinguish from intrinsic functions.

Cheers,
Tam

@tammasloughran
Copy link
Author

The changes to coding style like the spaces between the statements (eg. The open statement) and the parentheses options are a matter of tase. You can take them or leave them I guess; I forgot I put them in there.

@lpil
Copy link
Contributor

lpil commented Mar 4, 2021

Would it be possible to keep some of the triggers the same as before? Some people may be using them and I wouldn't want to mess up their workflow

@tammasloughran
Copy link
Author

Sure. You can always duplicate the snippets to have multiple triggers.

@tammasloughran
Copy link
Author

The only thing I feel strongly about is print and write. pr should be print *, and write should be the write statement. Having pr -> write is nonsensical because they are not the same thing. print is only intended to be used for displaying strings on the standard out. write is used for writing data to files and variables (coincidentally it can also be used to write to standard out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants