Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode the path for serve-static #42

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

ff2400t
Copy link
Contributor

@ff2400t ff2400t commented May 4, 2023

No description provided.

this is already how other adapters work
@yusukebe
Copy link
Member

yusukebe commented May 4, 2023

Thank you! I'll merge it.

@yusukebe yusukebe merged commit 4bb6bc2 into honojs:main May 4, 2023
mastondzn referenced this pull request in mastondzn/synopsisbot May 19, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@hono/node-server](https://github.com/honojs/node-server) |
[`^0.6.0` ->
`^1.0.0`](https://renovatebot.com/diffs/npm/@hono%2fnode-server/0.6.0/1.0.0)
|
[![age](https://badges.renovateapi.com/packages/npm/@hono%2fnode-server/1.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@hono%2fnode-server/1.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@hono%2fnode-server/1.0.0/compatibility-slim/0.6.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@hono%2fnode-server/1.0.0/confidence-slim/0.6.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/node-server</summary>

###
[`v1.0.0`](https://github.com/honojs/node-server/releases/tag/v1.0.0)

[Compare
Source](https://github.com/honojs/node-server/compare/v0.6.0...v1.0.0)

🎉 🎉 🎉

This is the first major release of the Hono Node server adapter!

#### Breaking Changes

From now on, the Node server adapter utilizes Node.js's native Web
Standard APIs, which have been available since version 18.x. Therefore,
you must use Node.js version 18 or higher.

Thanks to the use of these native APIs, the bundle size has been
significantly reduced!


![SS](https://user-images.githubusercontent.com/10682/235049566-126708ab-89f3-417b-b0f0-38121578054b.png)

This means that Hono is truly following Web Standards and is not
dependent on polyfills or other external libraries.

#### What's Changed

- decode the path for serve-static by
[@&#8203;ff2400t](https://github.com/ff2400t) in
[https://github.com/honojs/node-server/pull/42](https://github.com/honojs/node-server/pull/42)
- Feat/node18 by [@&#8203;tangye1234](https://github.com/tangye1234)
in
[https://github.com/honojs/node-server/pull/41](https://github.com/honojs/node-server/pull/41)
- feat(nextjs): obsolete a 2nd arg of `handle` by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/node-server/pull/43](https://github.com/honojs/node-server/pull/43)
- feat(adapter): rename `nextjs` to `vercel` by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/node-server/pull/45](https://github.com/honojs/node-server/pull/45)
- Next by [@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/node-server/pull/48](https://github.com/honojs/node-server/pull/48)

#### New Contributors

- [@&#8203;ff2400t](https://github.com/ff2400t) made their first
contribution in
[https://github.com/honojs/node-server/pull/42](https://github.com/honojs/node-server/pull/42)

**Full Changelog**:
honojs/node-server@v0.6.0...v1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/synopsisgg/bot).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45NS4xIiwidXBkYXRlZEluVmVyIjoiMzUuOTUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants