fix(serveStatic): add guard to prevent reading empty folders

[oussamasf]

#3628

This PR addresses an issue where attempting to open an empty directory with Deno.open returns a ReadableStream, causing unexpected behavior. Specifically, it leads to a status code 200 instead of the expected 404 for directories.

• Add tests
• Run tests
• bun run format:fix && bun run lint:fix to format the code
• Add TSDoc/JSDoc to document the code

[EdamAme-x]

I think this function is supposed to determine if the path is a directory...
If so, this may be a bug in serve-static as a whole.

https://github.com/honojs/hono/blob/main/src/adapter/deno/serve-static.ts#L25

Am I mistaken...?

[EdamAme-x]

@oussamasf

Adding the following to the beginning of your pull request is useful because it will automatically close the issue when it is merged!
Closes: https://github.com/honojs/hono/issues/3628

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (394a8f5) to head (7d4561d).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3639      +/-   ##
==========================================
+ Coverage   90.52%   91.68%   +1.15%     
==========================================
  Files         159      159              
  Lines       10179    10135      -44     
  Branches     2843     2862      +19     
==========================================
+ Hits         9215     9292      +77     
+ Misses        962      841     -121     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yusukebe]

Hi @oussamasf !

Thank you for the PR. Seems to be good. But, we need to write tests. Could you add a test for it? You can put it to runtime-tests/deno/middleware.test.tsx.

[oussamasf]

@EdamAme-x I replaced stat with the existing function
@yusukebe I added the minimum pattern (..as instructed in the comments of the test file)

[yusukebe]

LGTM!

[yusukebe]

@oussamasf

Looks good to me! Thank you for your contribution.

[alexgleason]

Thank you for fixing this!