feat(context): allow URL object on c.redirect()
#3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cometkim
force-pushed
the
url-redirect
branch
from
e349a00 to
94d3d86
Compare
|
Format check is not complete. It would also be a good idea to change the title to |
cometkim
force-pushed
the
url-redirect
branch
from
94d3d86 to
49efa65
Compare
cometkim
changed the title
c.redirect()c.redirect()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3609 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 158 158
Lines 9553 9553
Branches 2797 2819 +22
=======================================
Hits 9048 9048
Misses 505 505 ☔ View full report in Codecov by Sentry. |
EdamAme-x
suggested changes
Nov 1, 2024
Co-authored-by: EdamAmex <[email protected]>
|
Hi @cometkim I think this is a good improvement. Looks good to me. Thanks! |
TinsFox
pushed a commit
to TinsFox/hono
that referenced
this pull request
Nov 11, 2024
* feat(context): allow URL object on `c.redirect()` * Update src/context.ts Co-authored-by: EdamAmex <[email protected]> --------- Co-authored-by: EdamAmex <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code