Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hono-base): remove .matchRoute and reduce bundle size #3595

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(hono-base): remove .matchRoute and reduce bundle size #3595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/hono-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,6 @@ class Hono<E extends Env = Env, S extends Schema = {}, BasePath extends string =
this.routes.push(r)
}

private matchRoute(method: string, path: string) {
return this.router.match(method, path)
}

private handleError(err: unknown, c: Context<E>) {
if (err instanceof Error) {
return this.errorHandler(err, c)
Expand All @@ -406,7 +402,7 @@ class Hono<E extends Env = Env, S extends Schema = {}, BasePath extends string =
}

const path = this.getPath(request, { env })
const matchResult = this.matchRoute(method, path)
const matchResult = this.router.match(method, path)

const c = new Context(request, {
path,
Expand Down
Loading