feat(header): suggest name of header and combine in one file #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdamAme-x
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3577 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 157 158 +1
Lines 9539 9540 +1
Branches 2774 2784 +10
=======================================
+ Hits 9035 9036 +1
Misses 504 504 ☔ View full report in Codecov by Sentry. |
|
Hi @EdamAme-x Nice challenge! Looks good to me. I'll merge this and include it in the next patch release. Thanks! |
TinsFox
pushed a commit
to TinsFox/hono
that referenced
this pull request
Nov 11, 2024
…3577) * feat(header):ssuggest name of header and combine in one file * chore: format and fix jsr path * fix: fix types error of testing
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseHeader, AcceptHeader, etc. were combined and a new RequestHeader for suggestions was created.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code