Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bun/ws): supoort --hot #3576

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix(bun/ws): supoort --hot #3576

merged 1 commit into from
Oct 29, 2024

Conversation

nakasyou
Copy link
Contributor

Fixes #3559.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (f55dc45) to head (6a8b9cd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3576      +/-   ##
==========================================
- Coverage   94.71%   94.71%   -0.01%     
==========================================
  Files         157      157              
  Lines        9539     9537       -2     
  Branches     2798     2826      +28     
==========================================
- Hits         9035     9033       -2     
  Misses        504      504              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@nakasyou

I've confirmed it works well. Looks good. Let's go with it.

@yusukebe yusukebe merged commit cb8244a into honojs:main Oct 29, 2024
16 checks passed
@nakasyou nakasyou deleted the fix/bun-hot-ws branch October 29, 2024 06:06
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket on Bun throws an error after hot reloading
2 participants