fix(jsx/dom): fix memo for DOM renderer
#3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3568 +/- ##
=======================================
Coverage 94.71% 94.72%
=======================================
Files 157 157
Lines 9539 9551 +12
Branches 2819 2830 +11
=======================================
+ Hits 9035 9047 +12
Misses 504 504 ☔ View full report in Codecov by Sentry. |
|
I'll merge this now, though @sor4chi does not review it yet. Thanks! |
|
I was too busy to see it, sorry... |
|
@sor4chi Thanks for the review! |
TinsFox
pushed a commit
to TinsFox/hono
that referenced
this pull request
Nov 11, 2024
Fixes honojs#3473 Fixes honojs#3567 * fix(jsx/dom): fix memoization mechanism in dom renderer * fix(jsx/dom): fix `memo` for DOM renderer * feat(jsx/dom): implement light weight `memo` function for DOM renderer * test(jsx/dom): add tests for memoization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3473
#3567
The
jsx/dommemoization was generally behaving incorrectly, so I'm fixing it.12ee829
In the past, the code used the same approach as for
toString(),“holding memoized data in JavaScript memory,” but when rendering to the DOM, I found that memoization could be achieved by “not re-evaluate components” in the renderer, so the processing within the renderer was changed accordingly.Also, looking at the code generated by React Compiler, it seemed that React expected the ReactNode object generated by
jsx()to be cached and reused, and to be memoized, so I made it behave in the same way. I applied this branch to the code at https://github.com/sor4chi/explore-react-compiler-with-hono-jsx and confirmed that it was memoized.38a3c7e / 3b45b57
I changed the implementation of
memoso that memoization is done using a new mechanism.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code